Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static layeredArchitecture() function does not return LayeredArchitecture #986

Closed
timotuunanen opened this issue Oct 19, 2022 · 4 comments
Closed

Comments

@timotuunanen
Copy link

Hi.

I am using v1.0.0

In version 0.23.1 we were able to do the following:

layeredArchitecture()
        .layer("Application").definedBy("..application..")
        ...

, but in the latest version .layer() results unresolved reference as layeredArchitecture() returns DependencySettings instead of LayeredArchitecture. Is this intentional as javadoc still guides to use it the same way as in previous version?

@hankem
Copy link
Member

hankem commented Oct 19, 2022

Since v1.0.0-rc1,

layeredArchitecture() now forces to decide how to deal with dependencies by adding .consideringDependencies() in the beginning of the declaration. To restore the old behavior declare it as layeredArchitecture().consideringAllDependencies() (see #892).

This had unfortunately been overseen in the JavaDoc (also for 1.0.0) and only been fixed with #977 (currently not released yet).

@hankem
Copy link
Member

hankem commented Nov 2, 2022

@timotuunanen, can we close this issue already?

@codecholeric
Copy link
Collaborator

Closing this, since there hasn't been any activity. Feel free to reopen if your issue is not solved!

@hankem
Copy link
Member

hankem commented Nov 21, 2022

Release 1.0.1 with the fix is anyways available now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants