Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributing guidelines are no longer up to date #1300

Closed
johthor opened this issue May 24, 2023 · 1 comment · Fixed by #1303
Closed

Contributing guidelines are no longer up to date #1300

johthor opened this issue May 24, 2023 · 1 comment · Fixed by #1303
Assignees
@l-1squared
Labels
under development

Comments

@johthor
Copy link
Contributor

johthor commented May 24, 2023

As I have just discovered the project now requires a sign off on each commit which ist not mentioned in CONTRIBUTING.md.

Also the contributing guidelines still mentions JDK 8 while it seems to me that JDK 11 is now the minimum supported version.
@l-1squared
Copy link
Collaborator

Indeed, I have neglected that file a bit. Thanks for bringing this to my attention.

@l-1squared l-1squared self-assigned this May 25, 2023
@l-1squared l-1squared linked a pull request May 25, 2023 that will close this issue
Update contribution file #1303
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@l-1squared l-1squared

Labels
under development
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update contribution file TNG/JGiven
2 participants
@johthor @l-1squared