Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachment in JSON format in not written to a file #228

Closed
ahus1 opened this issue Aug 22, 2016 · 3 comments
Closed

Attachment in JSON format in not written to a file #228

ahus1 opened this issue Aug 22, 2016 · 3 comments

Comments

@ahus1
Copy link
Contributor

ahus1 commented Aug 22, 2016

If you define an attachment with MediaType JSON_UTF_8, no file is created by the HTML5 report.

Html5AttachmentGenerator will create only files for "text/" and "image/" types.

I would expect to have a file regardless media type (maybe with a default extension of "bin" like binary). For "application/json" the extension should be ".json".

Please comment if this is what other would expect as well. Thanks!

@janschaefer
Copy link
Contributor

Yes, that should be fixed.

@ahus1
Copy link
Contributor Author

ahus1 commented Oct 9, 2016

Started working on this one.

@janschaefer
Copy link
Contributor

Ok, great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants