You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That means, I'd have to inject fetching a default configuration (based on the path that is to be rendered) at this place.
However, the directory to render is calculated much later on (guides defines it as "docs", render-guides defines it as "Documentation" in a decorator).
So:
In the guides binary, I can influence additional loading of a guides.xml - but I cannot get the default "Documentation" render directory, because that is performed AFTER the guides.xml loading.
In our render-guides Decorator I can get the proper render directory, but I can no longer inject a guides.xml file (because the container is already built with the XML specifications as part of guides).
I could fetch a default "config" option in the case that a Directory is specified:
vendor/bin/guides Documentation
but I could not get the "right" directory name ("Documentation/") if I would call the binary just via:
vendor/bin/guides
So I think we'll need to retain '--config' as a mandatory argument.
In #421 I tried to adjust
guides
andrender-guides
so that it would use--config=Documentation
as a default.Since this idea was part of #421 where it didn't belong, and I failed with my approach, we may address this at a later time.
Description:
render-guides/packages/guides-cli/bin/guides
does a very early interpretation of the "config" attribute:https://github.com/phpDocumentor/guides/blob/main/packages/guides-cli/bin/guides#L54
That means, I'd have to inject fetching a default configuration (based on the path that is to be rendered) at this place.
However, the directory to render is calculated much later on (guides defines it as "docs", render-guides defines it as "Documentation" in a decorator).
So:
guides
binary, I can influence additional loading of a guides.xml - but I cannot get the default "Documentation" render directory, because that is performed AFTER the guides.xml loading.render-guides
Decorator I can get the proper render directory, but I can no longer inject a guides.xml file (because the container is already built with the XML specifications as part ofguides
).I could fetch a default "config" option in the case that a Directory is specified:
but I could not get the "right" directory name ("Documentation/") if I would call the binary just via:
So I think we'll need to retain '--config' as a mandatory argument.
For overview, current behavior:
My goal would be to make all four commands do the same: Render "Documentation", load "Documentation/guides.xml" and load "/guides.xml".
The text was updated successfully, but these errors were encountered: