[FEATURE] Reduce call get available sites for TYPO3 12.4 #4154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to PR: #4145 |
|
@sfroemkenjw |
|
Hi @dkd-kaehm I don't understand. After your approval you will get 3 options to merge my PR: Merge, Rebase and Squash. In TYPO3 docs team we always work this way. I have no clue how to squash commits on my side. Stefan |
|
OK I'll do the squash. |
dkd-kaehm
reviewed
Sep 20, 2024
|
Squashed and rebased to release-12.0.x on 2024.12.12 state. |
dkd-kaehm
pushed a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Dec 12, 2024
Use PHP generator with yield to process just the available sites needed How to test With over 300 root pages it needs over 30 seconds to build up all available sites. With help of a PHP generator we can stop processing all available sites if just the first site is requested. It's also helpful to just check, if there are available sites. This should speed up performance a lot. * Remove cache storing from <has> methods of SiteRepository * Use hasAvailableSites in ModuleController * Remove cache-set check from tests for SiteRepository * Move check for duplicate sites to getAvailableSites. PhpStan Fixes: TYPO3-Solr#3939 Replaces: TYPO3-Solr#4154
dkd-kaehm
pushed a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Dec 12, 2024
Use PHP generator with yield to process just the available sites needed How to test With over 300 root pages it needs over 30 seconds to build up all available sites. With help of a PHP generator we can stop processing all available sites if just the first site is requested. It's also helpful to just check, if there are available sites. This should speed up performance a lot. * Remove cache storing from <has> methods of SiteRepository * Use hasAvailableSites in ModuleController * Remove cache-set check from tests for SiteRepository * Repair unit tests * Move check for duplicate sites to getAvailableSites. PhpStan * Remove unused imports Fixes: TYPO3-Solr#3939 Ports: TYPO3-Solr#4154 Replaces: TYPO3-Solr#4145
|
Replaced by #4260 |
dkd-kaehm
changed the title
dkd-kaehm
pushed a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Dec 12, 2024
Use PHP generator with yield to process just the available sites needed How to test With over 300 root pages it needs over 30 seconds to build up all available sites. With help of a PHP generator we can stop processing all available sites if just the first site is requested. It's also helpful to just check, if there are available sites. This should speed up performance a lot. * Remove cache storing from <has> methods of SiteRepository * Use hasAvailableSites in ModuleController * Remove cache-set check from tests for SiteRepository * Repair unit tests * Move check for duplicate sites to getAvailableSites. PhpStan * Remove unused imports Fixes: TYPO3-Solr#3939 Ports: TYPO3-Solr#4154 Replaces: TYPO3-Solr#4145
dkd-kaehm
pushed a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Dec 17, 2024
Use PHP generator with yield to process just the available sites needed How to test With over 300 root pages it needs over 30 seconds to build up all available sites. With help of a PHP generator we can stop processing all available sites if just the first site is requested. It's also helpful to just check, if there are available sites. This should speed up performance a lot. * Remove cache storing from <has> methods of SiteRepository * Use hasAvailableSites in ModuleController * Remove cache-set check from tests for SiteRepository * Move check for duplicate sites to getAvailableSites. PhpStan Fixes: TYPO3-Solr#3939 Replaces: TYPO3-Solr#4154
dkd-kaehm
pushed a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Dec 17, 2024
Use PHP generator with yield to process just the available sites needed How to test With over 300 root pages it needs over 30 seconds to build up all available sites. With help of a PHP generator we can stop processing all available sites if just the first site is requested. It's also helpful to just check, if there are available sites. This should speed up performance a lot. * Remove cache storing from <has> methods of SiteRepository * Use hasAvailableSites in ModuleController * Remove cache-set check from tests for SiteRepository * Repair unit tests * Move check for duplicate sites to getAvailableSites. PhpStan * Remove unused imports Fixes: TYPO3-Solr#3939 Ports: TYPO3-Solr#4154 Replaces: TYPO3-Solr#4145
dkd-kaehm
pushed a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Dec 17, 2024
Use PHP generator with yield to process just the available sites needed How to test With over 300 root pages it needs over 30 seconds to build up all available sites. With help of a PHP generator we can stop processing all available sites if just the first site is requested. It's also helpful to just check, if there are available sites. This should speed up performance a lot. * Remove cache storing from <has> methods of SiteRepository * Use hasAvailableSites in ModuleController * Remove cache-set check from tests for SiteRepository * Repair unit tests * Move check for duplicate sites to getAvailableSites. PhpStan * Remove unused imports Fixes: TYPO3-Solr#3939 Ports: TYPO3-Solr#4154 Replaces: TYPO3-Solr#4145
dkd-kaehm
pushed a commit
that referenced
this pull request
Dec 17, 2024
Use PHP generator with yield to process just the available sites needed How to test With over 300 root pages it needs over 30 seconds to build up all available sites. With help of a PHP generator we can stop processing all available sites if just the first site is requested. It's also helpful to just check, if there are available sites. This should speed up performance a lot. * Remove cache storing from <has> methods of SiteRepository * Use hasAvailableSites in ModuleController * Remove cache-set check from tests for SiteRepository * Move check for duplicate sites to getAvailableSites. PhpStan Fixes: #3939 Replaces: #4154
dkd-kaehm
pushed a commit
that referenced
this pull request
Dec 17, 2024
Use PHP generator with yield to process just the available sites needed How to test With over 300 root pages it needs over 30 seconds to build up all available sites. With help of a PHP generator we can stop processing all available sites if just the first site is requested. It's also helpful to just check, if there are available sites. This should speed up performance a lot. * Remove cache storing from <has> methods of SiteRepository * Use hasAvailableSites in ModuleController * Remove cache-set check from tests for SiteRepository * Repair unit tests * Move check for duplicate sites to getAvailableSites. PhpStan * Remove unused imports Fixes: #3939 Ports: #4154 Replaces: #4145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does?
Use PHP generator with yield to process just the available sites needed
How to test
With over 300 root pages it needs over 30 seconds to build up all available sites. With help of a PHP generator we can stop processing all available sites if just the first site is requested. It's also helpful to just check, if there are available sites.
This should speed up performance a lot.