Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codemods for v5 #4705

Closed
TkDodo opened this issue Dec 25, 2022 · 11 comments · Fixed by #5046
Closed

codemods for v5 #4705

TkDodo opened this issue Dec 25, 2022 · 11 comments · Fixed by #5046
Assignees
Labels
Milestone

Comments

@TkDodo
Copy link
Collaborator

TkDodo commented Dec 25, 2022

for breaking syntax changes:

@balazsmatepetro let me know if you want to work on this :)

@TkDodo TkDodo added the v5 label Dec 25, 2022
@TkDodo TkDodo added this to the v5 milestone Dec 25, 2022
@moaoa
Copy link

moaoa commented Dec 26, 2022

I am interested

@balazsmatepetro
Copy link
Contributor

balazsmatepetro commented Dec 26, 2022

@TkDodo of course! :) Feel free to assign some tasks to me.

@TkDodo
Copy link
Collaborator Author

TkDodo commented Dec 26, 2022

We can also split the work into multiple codemods - just want to avoid two people doing the same work :)

@balazsmatepetro
Copy link
Contributor

We can also split the work into multiple codemods - just want to avoid two people doing the same work :)

Sounds like a plan. ;)

@TkDodo
Copy link
Collaborator Author

TkDodo commented Jan 17, 2023

@balazsmatepetro will take care of the first code-mod for remove overloads because:

  • it will be easier to parallelize and write codemods for other things after that because we'll only have one object structure to care about
  • we will need to do some restructurings in the packages to support codemods for multiple frameworks

@moaoa
Copy link

moaoa commented Jan 17, 2023

Hello there

I have some experience with code mods and can help can you guys give some guidance

@TkDodo
Copy link
Collaborator Author

TkDodo commented Mar 6, 2023

@moaoa if you want, please review the PR for the overloads removal codemod:

@TkDodo TkDodo linked a pull request Mar 6, 2023 that will close this issue
@moaoa
Copy link

moaoa commented Mar 6, 2023

OK I will look into that @TkDodo

@TkDodo
Copy link
Collaborator Author

TkDodo commented Jun 8, 2023

@moaoa we have a separate package now for codemods. Let me know if you want to contribute one :)

@moaoa
Copy link

moaoa commented Jun 12, 2023

Great
I have exams in the next two weeks
As soon as I finish I will look into that
@TkDodo

@TkDodo
Copy link
Collaborator Author

TkDodo commented Jul 21, 2023

I created separate issues for the remaining codemods:

https://github.com/TanStack/query/issues?q=is%3Aissue+is%3Aopen+codemod

@TkDodo TkDodo closed this as completed Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants