Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some layout issues #1879

Closed
kgebert opened this issue Jun 26, 2022 · 7 comments
Closed

Some layout issues #1879

kgebert opened this issue Jun 26, 2022 · 7 comments
Labels
bug Something isn't working frontend issues that affect frontend (Vue/JS) or only django template code
Milestone

Comments

@kgebert
Copy link
Contributor

kgebert commented Jun 26, 2022

Tandoor Version

Beta 20.06.2022

Setup

Docker / Docker-Compose

Reverse Proxy

Nginx Proxy Manager (NPM)

Other

No response

Bug description

grafik

The following layout issues are in the recipe view (see also screenshot):

  • The ingredients and the description are not aligned anymore.
  • In the first step only, the name of the step is duplicated to the ingredients list.
  • In the first step only, the remark bubble sticks to close to the ingredient.

Relevant logs

No response

@vabene1111
Copy link
Collaborator

i noticed something off about the ingredients table too, need to look into why this broke. thanks fore summing this up

@vabene1111 vabene1111 added this to the 1.3.0 milestone Jun 28, 2022
@vabene1111 vabene1111 added bug Something isn't working frontend issues that affect frontend (Vue/JS) or only django template code labels Jun 28, 2022
@vabene1111
Copy link
Collaborator

should be fixed in the next release, let me know if there is anything left for your screen size

@kgebert
Copy link
Contributor Author

kgebert commented Jun 30, 2022

Much better now. One issue, though
image

The name of step one is displayed in the ingredients list. The name of the other steps are not.

@vabene1111
Copy link
Collaborator

that depends if you set the step header to show, the fact that the default is still not equal is something i need to fix but basically next to the step name there is a button (in the editor) which decides if the name should be shown in the overview or not.

I will fix the inconsistent defaults

@kgebert
Copy link
Contributor Author

kgebert commented Jul 1, 2022

Ah, OK. Didn't know that. It could be that I've accidentally clicked that button.

@vabene1111
Copy link
Collaborator

no i think you did nothing wrong, i messed up the defaults at some point and need to see if they are correct now, maybe its just an older recipe in your instance or maybe the defaults are still wrong.

@vabene1111
Copy link
Collaborator

ok its just and old recipe from the time this was broken, everything is fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend issues that affect frontend (Vue/JS) or only django template code
Projects
None yet
Development

No branches or pull requests

2 participants