Not able to create a public share link for recipes of a space the user is not owner of

[kgebert]

Tandoor Version

1.3.3

Setup

Docker / Docker-Compose

Reverse Proxy

Nginx Proxy Manager (NPM)

Other

No response

Bug description

Me, my sister and my brother are sharing an installation of Tandoor. We have a dedicated recipe space for each and given each other read permissions.
I'm able to publicly share recipes of my own space. Currently I noticed that I'm not able to share recipes of my sister. When clicking Share, I get the following pop-up:

The public share link is not generated correctly.

• Either the link should be generated correctly...
• or - if it is not allowed to share recipes of others - the function should be disabled.

(This could be related to Share link doesn't work between spaces for logged in users #1238).

Relevant logs

No response

[kgebert]

FYI: Just updated to 1.3.3 and this issue is still there.

[vabene1111]

Interesting, thanks for reporting. I guess that's something I never tested.

In the long term this should probably also be a seperate permission.

[vabene1111]

ok so the problem was actually that you gave each other guest (read only) permission. a guest cannot create a share link (because he is only a guest). I added a proper error message but will rework the permission system in the future to improve this further and make it possible to select those permissions individually