Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve json-ld import #3253

Closed
emouty opened this issue Aug 11, 2024 · 1 comment
Closed

Improve json-ld import #3253

emouty opened this issue Aug 11, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@emouty
Copy link

emouty commented Aug 11, 2024

Is your feature request related to a problem? Please describe.

Hello, I'm using llms to structure unstructured recipes into the json-ld recipe format then import them in tandoor.
The issue is that when importing a recipe in json-ld using the source tab, if this recipe have multiple HowToSection it result in a single step and if one of the HowToSection have an element in itemListElement of type recipe it is just ignored.

recipe example:

{
  "@context": "http://schema.org/",
  "@type": "Recipe",
  "name": "Victoria Sponge",
  "recipeIngredient": [
    "200g sugar",
    "200g butter",
    "4 eggs",
    "200g flour",
    "1 tsp baking powder",
    "2 tbsp milk"
  ],
  "recipeInstructions": [
    {
      "@type": "HowToSection",
      "name": "Sponge",
      "itemListElement": [
        {
          "@type": "HowToStep",
          "text": "Preheat oven to 180C."
        },
        {
          "@type": "HowToStep",
          "text": "Mix sugar and butter."
        }
      ]
    },
    {
        "@type": "HowToSection",
        "name": "Bake",
        "itemListElement": [
          {
            "@type": "HowToStep",
            "text": "Put the sponge in the hoven for 20 minutes"
          }
        ]
      },
    {
      "@type": "HowToSection",
      "name": "Filling",
      "itemListElement": [
        {
          "@type": "Recipe",
          "name": "Filling",
          "recipeIngredient": ["100g jam", "100g cream"],
          "recipeInstructions": [
            {
              "@type": "HowToStep",
              "text": "Spread jam on one sponge."
            }
          ]
        }
      ]
    }
  ]
}

Describe the solution you'd like

I would expect that each HowToSection result in a different step in tandoor and when the HowToSection.itemListElement contains an item of type recipe its turn it into a step like HowToSection and the ingredients listed in it would end up being ingredients of the step.

Describe alternatives you've considered

I originally wanted to target the default tandoor recipes format but I couldn't find a clear schema of it and import for default tandoor format require to compress the file into a zip archive.

Additional context

No response

@emouty emouty added the enhancement New feature or request label Aug 11, 2024
@smilerz
Copy link
Collaborator

smilerz commented Aug 11, 2024

Sites do not use multiple HowTo steps in a consistent manner.

@smilerz smilerz closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants