Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TxLog to Goroutine #103

Merged
merged 2 commits into from
Apr 22, 2023
Merged

TxLog to Goroutine #103

merged 2 commits into from
Apr 22, 2023

Conversation

TanmoySG
Copy link
Owner

Closes #101

  • Moved txlog method handleTransactions to separate thread with goroutine

Note:

  • Might require additional panic handling for goroutine, currently not being handled by the default panic handler in server/middleware/recovery, though haven't encountered any panics for current code/tests

@TanmoySG TanmoySG self-assigned this Apr 22, 2023
@TanmoySG TanmoySG added enhancement New feature or request go Pull requests that update Go code labels Apr 22, 2023
@TanmoySG TanmoySG merged commit f69590e into main Apr 22, 2023
@TanmoySG TanmoySG deleted the txlog-routine branch April 22, 2023 20:41
TanmoySG added a commit that referenced this pull request Apr 23, 2023
@TanmoySG
Revert Async txn logging [Revert #103] #104
5db33a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TanmoySG TanmoySG

Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TxLogs] Move TxLogs commit (append to file) in a Separate Thread
1 participant
@TanmoySG