Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global app variable #29

Closed
Tbruno25 opened this issue Jul 2, 2024 · 1 comment
Closed

Remove global app variable #29

Tbruno25 opened this issue Jul 2, 2024 · 1 comment

Comments

@Tbruno25
Copy link
Owner

Tbruno25 commented Jul 2, 2024

Currently a singleton can_explorer.app.app is created on import and referenced as a global variable. This leads to false failures and potential strange behavior when testing as experienced in #28.

A better design pattern should be utilized and all global references removed. d3c50b6 should also be reverted as it's a temporary fix to avoid the behavior.

@Tbruno25
Copy link
Owner Author

Global variables removed as part of #31 however the false failures remain.

#32 opened to track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant