🔀 :: [#142] ModalViewController의 dismiss가 subviews를 눌러도 적용되는 현상 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 개요
ModalViewController에서 빈화면을 누를때만이 아니라 실제 content가 들어가있는 contentView를 누를때 똑같이 dismiss route를 보내는 현상이 있었음
📃 작업내용
tapGesturePublisher에서 해당 gesture의 view인지 검사
🔀 변경사항
gesture의 touch인식 view를 해당 gesture를 추가한 view인지 검사