Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Member page cannot be submitted with RFID field blank #110

Closed
ryanstrat opened this issue Apr 2, 2017 · 4 comments · Fixed by #134
Closed

Admin Member page cannot be submitted with RFID field blank #110

ryanstrat opened this issue Apr 2, 2017 · 4 comments · Fixed by #134
Assignees
Labels
Milestone

Comments

@ryanstrat
Copy link
Contributor

No description provided.

@ryanstrat ryanstrat added this to the Sprint 5 milestone Apr 2, 2017
@ryanstrat ryanstrat self-assigned this Apr 2, 2017
@thomascoe thomascoe added the bug label Apr 3, 2017
@thomascoe
Copy link
Contributor

Also we may want to allow blank expiration date? People like Makerspace admins may not have an expiration date

@thomascoe
Copy link
Contributor

Okay so in master now I reverted back to requiring an RFID. I tried to have it submit with an empty RFID number but I kept getting errors from G Suite, something about it it didn't like. So maybe we should just leave it at requiring RFID? Unless someone else can figure out the G Suite issue

@thomascoe
Copy link
Contributor

Okay I removed the restriction from the form and just treated a stored 0 as an empty value

@ryanstrat
Copy link
Contributor Author

Sounds like a good solution! I think the G Suite wrapper was treating the empty string as a null value, which ends up not being sent to the server. There's a special constant you can send that's documented. but I think this solution is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants