Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add member tab to tab bar #97

Closed
danaalyse opened this issue Mar 31, 2017 · 9 comments
Closed

Add member tab to tab bar #97

danaalyse opened this issue Mar 31, 2017 · 9 comments
Assignees
Labels
Milestone

Comments

@danaalyse
Copy link
Contributor

No description provided.

@danaalyse danaalyse added this to the Sprint 5 milestone Mar 31, 2017
@thomascoe thomascoe added the UI label Apr 3, 2017
@thomascoe
Copy link
Contributor

Tab bar on main makerspace site. This may need to be done manually and not by the plugin?

@thomascoe thomascoe modified the milestones: Demo, Sprint 5 Apr 16, 2017
@ryanstrat
Copy link
Contributor

I'll take a stab at this

@ryanstrat
Copy link
Contributor

The member page is added. I can't find a way to make it show up only if logged in, so I'm making it attempt login if clicked by a non-logged in user.

@thomascoe
Copy link
Contributor

Yeah, the member page itself should redirect to log-in if you aren't logged in already. Currently it gives this error:
image

@ryanstrat
Copy link
Contributor

I have the code to catch the error in the login branch, but I'm not really sure what to do with it. I haven't found a way to trigger a login. I'm going to spend more time digging through the code for the login plugin to do that.

@ryanstrat
Copy link
Contributor

Thoughts on creating a new page that I can redirect to and the only content on the page is a login widget?

@thomascoe thomascoe modified the milestones: Sprint 5, Demo Apr 18, 2017
@thomascoe
Copy link
Contributor

Just make a failure page modeled off failure.html

@ryanstrat ryanstrat mentioned this issue Apr 24, 2017
@thomascoe
Copy link
Contributor

This redirects to the wordpress login page. It should probably redirect to the google login page instead. Or show an error. I think redirecting to wp login is incorrect though

@thomascoe
Copy link
Contributor

With the new google login plugin the DecaturMakers will be using, the wp login page will be replaced with Google login, so the functionality in master will be correct for them. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants