Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE on SearchView#updateResultList #4140

Closed
amaze-issue-automation bot opened this issue Apr 4, 2024 · 4 comments · Fixed by #4230
Closed

NPE on SearchView#updateResultList #4140

amaze-issue-automation bot opened this issue Apr 4, 2024 · 4 comments · Fixed by #4230
Assignees
Labels
Crash-NullPointerException From-telegram Issue reported through telegram channel Issue-Bug Related unexpected behavior or something worth investigating. Issue-Easy (good first issue) Beginners welcome! Issues with relative low difficulty.
Milestone

Comments

@amaze-issue-automation
Copy link

Issue explanation (write below this line)

Exception

  • App Name: Amaze File Manager
  • Package: com.amaze.filemanager
  • Version: 3.10
  • User Action: UI Error
  • Request: Application crash
  • OS: Linux Android 14 - 34
  • Device: e1s
  • Model: SM-S921B
  • Product: e1sxxx
Crash log

java.lang.NullPointerException: Attempt to invoke interface method 'java.lang.Object[] java.util.Collection.toArray()' on a null object reference
at java.util.ArrayList.(ArrayList.java:188)
at com.amaze.filemanager.ui.views.appbar.SearchView.updateResultList(SearchView.java:375)
at com.amaze.filemanager.ui.views.appbar.SearchView.onSortTypeSelected(SearchView.java:481)
at com.amaze.filemanager.ui.views.appbar.SearchView.lambda$showSearchResultsSortDialog$11(SearchView.java:469)
at com.amaze.filemanager.ui.views.appbar.SearchView.$r8$lambda$d_i92XacrdBgqH38-DZKwptUe_8(Unknown Source:0)
at com.amaze.filemanager.ui.views.appbar.SearchView$$ExternalSyntheticLambda10.onClick(Unknown Source:2)
at com.afollestad.materialdialogs.MaterialDialog.onClick(MaterialDialog.java:410)
at android.view.View.performClick(View.java:8047)
at android.widget.TextView.performClick(TextView.java:17793)
at android.view.View.performClickInternal(View.java:8024)
at android.view.View.-$$Nest$mperformClickInternal(Unknown Source:0)
at android.view.View$PerformClick.run(View.java:31890)
at android.os.Handler.handleCallback(Handler.java:958)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:230)
at android.os.Looper.loop(Looper.java:319)
at android.app.ActivityThread.main(ActivityThread.java:8918)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:608)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1103)


Reporter: softdev1999

@amaze-issue-automation amaze-issue-automation bot added the From-telegram Issue reported through telegram channel label Apr 4, 2024
@VishnuSanal VishnuSanal changed the title Crash reported by softdev1999 NPE on SearchView#updateResultList Apr 7, 2024
@VishnuSanal VishnuSanal added Issue-Bug Related unexpected behavior or something worth investigating. Crash-NullPointerException Issue-Easy (good first issue) Beginners welcome! Issues with relative low difficulty. labels Apr 7, 2024
@hammadrfq3
Copy link
Contributor

Can I contribute to this issue?

@hammadrfq3
Copy link
Contributor

@VishnuSanal This issue is resolved in this #4222 pull request. Now, I need to create a separate pull request for this issue or not?

@VishnuSanal
Copy link
Member

@VishnuSanal This issue is resolved in this #4222 pull request. Now, I need to create a separate pull request for this issue or not?

Didn't get you? Did you mean that the solution to this issue was added in #4222, even though it is unrelated or that this issue was fixed in #4222 by chance, due to the code rewrite?

The latter possibility seems distant to me since both are unrelated. If it is so, please open an individual PR for each individual issue.

@hammadrfq3
Copy link
Contributor

hammadrfq3 commented Jul 24, 2024

@VishnuSanal This issue is resolved in this #4222 pull request. Now, I need to create a separate pull request for this issue or not?

Didn't get you? Did you mean that the solution to this issue was added in #4222, even though it is unrelated or that this issue was fixed in #4222 by chance, due to the code rewrite?

The latter possibility seems distant to me since both are unrelated. If it is so, please open an individual PR for each individual issue.

Ok, I will create separate PR for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crash-NullPointerException From-telegram Issue reported through telegram channel Issue-Bug Related unexpected behavior or something worth investigating. Issue-Easy (good first issue) Beginners welcome! Issues with relative low difficulty.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants