-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brightness bug when "changing player" (after unified player, 2907) #4043
Comments
You can still watch a video in portrait mode and the brightness you setup is needed in this case. |
then play fullscreen, otherwise the rest of the screen will burn your eyes.
I totally agree. The reverse thing also apply: when not playing a video, the brightness should be lower. If you want higher brightness on video details or minized, just increase your system brightness or play in fullscreen, because most of the screen is not about the video. And even worse when you read comments or close the minimized state (when you scroll down), nothing on the screen is about video but we keep video brightness… |
I think this should be prioritized as it's missing badly with our eyes 🤤 |
Wow, it was worse than I thought. The brightness value persists across app restarts and shows up again when you open video details. But strangely, when you go fullscreen the brightness lowers to system level. And even more strangely, it goes back to the high value if you go back to video details. Very weird. Anyway, this was a much needed fix, so thanks, @avently. |
This is how it works for years :)
Nope, it's the same as was set in videoplayerfragment, no changes
Still no, if you just watched a video in fullscreen and than rotated to portrait the brightness will be the same as was set by videodetailsfragment after initial load. Anyway, after the PR the brightness will work the same way expect it will be set only for fullscreen mode. Or will be system default otherwise. |
Yes, but that was the correct behaviour in that case, because the video player was the only place with that high brightness. The video details page was still at system brightness. With the unified player, the video details page was consequently made high brightness as well, which is why this was considered a bug. The behaviour after your fix is more intuitive. |
Version
Steps to reproduce the bug
Expected behavior
The brightness is back to system brightness. The fullscreen brightness is only used in fullscreen, not in video details or popup player (not the case with the last one).
Actual behaviour
The brightness is the same as the fullscreen video brightness. With step 6, it's really stupid because the video isn't even playing but we still have this brightness, and no way to change it except play a new video and lower brightness.
The text was updated successfully, but these errors were encountered: