Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitle text area is smaller for no reason than 0.19.8 #4294

Closed
B0pol opened this issue Sep 19, 2020 · 6 comments · Fixed by #4272
Closed

Subtitle text area is smaller for no reason than 0.19.8 #4294

B0pol opened this issue Sep 19, 2020 · 6 comments · Fixed by #4272
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface

Comments

@B0pol
Copy link
Member

B0pol commented Sep 19, 2020

Version

Steps to reproduce the bug

  1. set newpipe language to french
  2. open a video with subtitles; e.g. https://invidious.snopyta.org/watch?v=58hoktsqk_Q
  3. press the arrow button

Expected behavior

If there is room, notice "Aucun sous-titre" (no subtitles)

Actual behaviour

There is room for it but only "Aucun sous…" is shown

Screenshots/Screen recordings

newpipe_0_19_8_subtitles

newpipe_0_20_0_pre-version

Logs

@B0pol B0pol added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Sep 19, 2020
@avently
Copy link
Contributor

avently commented Sep 19, 2020

The reason is portrait mode and long caption name

For example, choose russian language (русский язык) and this video in portrait with Kore enabled in settings (you'll have 4 buttons in a row with a caption english (создано автоматически)): https://www.youtube.com/watch?v=TDiXxsQ0w2Q

@B0pol
Copy link
Member Author

B0pol commented Sep 19, 2020

That's a reason for portrait mode, not for landscape. In landscape there is more space, hence it should be larger.

@opusforlife2
Copy link
Collaborator

Can the width be dynamic? That is, from the Fit setting until wherever the first drop down setting icon starts, plus some padding space.

@avently
Copy link
Contributor

avently commented Sep 19, 2020

It can be dynamic but it that case I need to replace LinearLayout with RelativeLayout which will hurt performance and I don't want this. I will make the maxWidth based on window size. So on small window (regardless of landscape because you can have the app in landscape but in multiwindow mode with small app window) the caption will be shorted and longer in a large window

@opusforlife2
Copy link
Collaborator

Oh. Good point. It's not important enough to sacrifice performance.

@avently
Copy link
Contributor

avently commented Sep 19, 2020

#4272 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants