Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bandcamp path prefix is hindering functionality #6335

Closed
4 tasks done
goyalyashpal opened this issue May 20, 2021 · 1 comment · Fixed by #6373
Closed
4 tasks done

Bandcamp path prefix is hindering functionality #6335

goyalyashpal opened this issue May 20, 2021 · 1 comment · Fixed by #6373
Labels
bandcamp Service, https://bandcamp.com/ bug Issue is related to a bug

Comments

@goyalyashpal
Copy link
Contributor

goyalyashpal commented May 20, 2021

Checklist

Steps to reproduce the bug

click the following links on android
Copy paste the following links in telegram app and click on them one by one from there.

https://laurashigihara.bandcamp.com

https://reinhardtbuhr.bandcamp.com

https://laurashigihara.bandcamp.com/

https://reinhardtbuhr.bandcamp.com/

Actual behaviour

the bandcamp domain links without / in the end dont show newpipe in the open-with / app-selection / disambiguation dialog.

Expected behavior

both should

Environment info

  • Android version/Custom ROM version: 7.0
  • Device model: Prime P30
  • NewPipe source: Newpipe repo
@goyalyashpal goyalyashpal added the bug Issue is related to a bug label May 20, 2021
@goyalyashpal
Copy link
Contributor Author

goyalyashpal commented May 20, 2021

the bandcamp album/song links are with *.bandcamp.com/*/* i.e. contain a slash after *.bandicam.com so are no problem.

This is very likely due to data android:pathPrefix="/" in the Bandcamp <intent-filter> in AndroidManifest.xml . i tried to experiment with that , but got stuck up in gradle errors while building the apk for testing.

goyalyashpal@2a54c12 :

--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -332,7 +332,6 @@
                <data android:scheme="https"/>
                <data android:host="bandcamp.com"/>
                <data android:host="*.bandcamp.com"/>
-               <data android:pathPrefix="/"/>
            </intent-filter>
        </activity>
        <service

taking the diff syntax from #6184


Reverse Trail 0 :

@AudricV AudricV added the bandcamp Service, https://bandcamp.com/ label May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bandcamp Service, https://bandcamp.com/ bug Issue is related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants