Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nitpick] Uninstaller doesn't remove all files added from the installer #498

Closed
Joehuu opened this issue Feb 22, 2022 · 5 comments
Closed
Assignees
Labels
Platform: Windows Affects Windows Operating System Status: In Progress We are working on this one! Type: Bug Something is broken in the code

Comments

@Joehuu
Copy link

Joehuu commented Feb 22, 2022

Game Mode

No response

Give an example of what is wrong

These are the files that are left over after immediately uninstalling:

image image image

I know the files from the first image were added after #115, but the uninstaller didn't get updated to include those files.

Give an example of what it should look like

I tested with the StepMania 5.0.12 installer and immediately uninstalled. It removed all the files including the StepMania 5 folder. I expect it to be the case here also.

@MatthewDog42
Copy link

It leaves those files on purpose. It deletes and reinstalls them after reinstalling the game again.

@Joehuu
Copy link
Author

Joehuu commented Feb 22, 2022

I don't think so, because the other preset avatars do get removed after uninstalling.

@Scraticus Scraticus self-assigned this Mar 24, 2022
@Scraticus Scraticus added Type: Bug Something is broken in the code Platform: Windows Affects Windows Operating System Status: In Progress We are working on this one! labels Mar 24, 2022
@Scraticus
Copy link
Member

Fixed in 4.14, Liro missed these on the installer script. Thanks for reporting.

@Joehuu
Copy link
Author

Joehuu commented Mar 26, 2022

Checking again in the new update, the newly added judgments and an empty folder are not removed.

image image

@Jousway
Copy link
Member

Jousway commented Mar 26, 2022

well when you uninstall the new version they will be, because the uninstaller is set up using the current installed version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Windows Affects Windows Operating System Status: In Progress We are working on this one! Type: Bug Something is broken in the code
Projects
None yet
Development

No branches or pull requests

4 participants