-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Version 2.0 #15
Draft
WesleyMcGinn
wants to merge
63
commits into
main
Choose a base branch
from
speaking-snail
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The popup page will allow for basic adjustments of size, speed, colour, etc., while the options page will have the same settings and more, especially including checkboxes for what the snail may talk about.
The favicon is not needed for an extension popup as it will not be displayed anyways.
Rounded three corners more to make the point more distinct. This makes it easier to see it as a word bubble and harder to mistake it for a random floating box of text.
The snail's size and speed will be changed as the user is moving the slider, but the new value will not be saved until the mouse button is released on the slider.
The data in Chrome sync, changed by the options page, will be retrieved here and will tell the snail what to talk about. If someone unchecks the box for the snail reminding them that their battery level is low, then the snail should not talk about it.
This would not allow for any preview of snail speed while adjusting.
Google Translate can work on these pages now and the extension can reach a wider audience.
Responsive Web Design!
There only has to be one call to Chrome for the retrieval of sync data.
The AI does not have to be retrained every time the randomize button is clicked.
Opens options.html.
When the snail is made visible by javascript, it will still not be visible when you try to print the page you are on.
These will be used to prevent the snails from stating the same fun fact or breaking news multiple times in one day.
Battery level 0% indicates Chrome battery-detection error.
Previously, when the slider for setting the snail's size or speed was dragged to other endpoint but the mouse button was released while the mouse was not on the slider, the new setting would not save. Now, when previewing a maximum/minimum size or speed, as soon as the slider hits the end the setting will be saved to Chrome sync.
A function with a shorter name (`$`) replaced a very common function with a longer name (`document.getElementById`).
This situation will be dealt with later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains code for MySnail 2.0. The extension has improved in various ways, including, but not limited to, the following improvements:
Resolves #2.
Do not merge until completed. The checklist above shows what has already been programmed into the snail.