Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copier update: backup.env overwritten #275

Open
sgheller opened this issue Sep 26, 2021 · 1 comment
Open

Copier update: backup.env overwritten #275

sgheller opened this issue Sep 26, 2021 · 1 comment
Labels
bug Something isn't working hacktoberfest Good for newcomers help wanted Extra attention is needed

Comments

@sgheller
Copy link
Contributor

sgheller commented Sep 26, 2021

Describe the bug

After copier update, pre-existing aws credentials and backup passphrase are overwritten in .docker/backup.env.
Credentials defaults to null and are deleted from the env file. Passphrase changes to "example-backup-passphrase".
Because .docker/ is gitignored, this changes may go unnoticed.

To Reproduce

Steps to reproduce the behavior:

  1. Use copier update to add my aws credentials and backup passphrase
  2. Use copier update to update the project when there are changes in this template
  3. Skip copier questions about backup credentials and passphrase

Expected behavior: Docs state that default values will be those you answered last time. If I don't want to change credentials and passphrase then when I press enter I expect them not to change.

@sgheller sgheller added the bug Something isn't working label Sep 26, 2021
@yajo yajo added hacktoberfest Good for newcomers help wanted Extra attention is needed labels Sep 27, 2021
@yajo
Copy link
Contributor

yajo commented Sep 27, 2021

The fix would be simple:

  1. Add .docker/* to _skip_if_exists in copier.yml.
  2. Add a test asserting that this works fine.

PRs welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants