Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

fix remove group (closes #29) #30

Merged
merged 1 commit into from
Sep 23, 2016
Merged

fix remove group (closes #29) #30

merged 1 commit into from
Sep 23, 2016

Conversation

gerson24
Copy link
Contributor

No description provided.

rsoletob
rsoletob suggested changes Sep 23, 2016
View reviewed changes
database/postgresql/group_test.go
t.Errorf("Test %v failed. Unexpected error counting total group policy relations: %v", n, err)
continue
}
if relations != 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totalRelations?

database/postgresql/group_test.go
@@ -803,13 +826,35 @@ func TestPostgresRepo_RemoveGroup(t *testing.T) {
// Check total group user relations
totalRelations, err := getGroupUserRelations("", "")
if err != nil {
t.Errorf("Test %v failed. Unexpected error counting total relations: %v", n, err)
t.Errorf("Test %v failed. Unexpected error counting total group user relations: %v", n, err)
continue
}
if relations != 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totalRelations?

@gerson24 gerson24 merged commit bf45d7e into master Sep 23, 2016
@gerson24 gerson24 deleted the 29-fix-remove-group branch September 23, 2016 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rsoletob rsoletob rsoletob approved these changes

@sergiogarcia94 sergiogarcia94 sergiogarcia94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gerson24 @rsoletob @sergiogarcia94