Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.0.0 #269

Closed
justinmayer opened this issue Apr 10, 2023 · 10 comments · Fixed by #281
Closed

Release v1.0.0 #269

justinmayer opened this issue Apr 10, 2023 · 10 comments · Fixed by #281

Comments

@justinmayer
Copy link
Collaborator

In an effort to avert the absurdity that is ZeroVer, I propose the next pytest-sugar release be anointed v1.0.0, perhaps in conjunction with officially dropping support for Python 3.7, which will very soon reach its end-of-life date.

@vladgurovich
Copy link

vladgurovich commented Apr 12, 2023

Agree @justinmayer -- I do wish that would have happened before the pytest requirements were increased by several major versions in v0.9.7:

@auvipy
Copy link
Collaborator

auvipy commented Apr 13, 2023

we can keep 3.7 in the v1.0.0 release and drop in next release v1.1.0

@justinmayer
Copy link
Collaborator Author

justinmayer commented Apr 13, 2023

@vladgurovich: It was not clear that those minimum Pytest version changes were not already in a shipped release — otherwise I would have indeed pushed for this last release to be v1.0.0. In any case, I do not know that there's much we can do about that now, right? Is this situation enough of a problem that it warrants yanking the v0.9.7 release from PyPI and re-releasing as v1.0.0?

@auvipy: I do not understand. What would that achieve? Python 3.7 is already the minimum supported version.

@auvipy
Copy link
Collaborator

auvipy commented Apr 13, 2023

yes and just keeping that until v1.0.0 unless it is released few months later of EOL of 3.7 will llet users of old systems easier path to upgrade.

@justinmayer
Copy link
Collaborator Author

I'm not sure what will change in the next two months to make it easier for folks on older systems to upgrade from Python 3.7 to a newer version, so personally I don't think the stated reason is enough to warrant waiting until June to require Python 3.8+.

Other popular packages have already made this change: Flake8, isort, etc.

@auvipy
Copy link
Collaborator

auvipy commented Apr 13, 2023

celery hasn't dropped it yet and will wait until june and next major release v5.3 will include py3.7, although I wanted to drop it but celery is used by lots of old system & big enterprise, so we can't be too aggresive in dropping support.

@hugovk
Copy link
Contributor

hugovk commented Jan 28, 2024

pytest 8.0.0 was released yesterday:

https://docs.pytest.org/en/latest/changelog.html#pytest-8-0-0-2024-01-27

Please could you make a new release with the #278 fix? It's needed to use pytest-sugar with pytest 8.

Thanks!

@justinmayer
Copy link
Collaborator Author

Indeed — once #280 has been merged, I will prepare a release. 👍

@justinmayer
Copy link
Collaborator Author

I merged #280 and submitted PR #281. When the latter PR is merged, pytest-sugar v1.0.0 will be automatically released.

@justinmayer
Copy link
Collaborator Author

pytest-sugar 1.0.0 has been released, and the package is now available on PyPI 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants