Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Meson #12

Closed
nullgemm opened this issue Oct 8, 2021 · 5 comments
Closed

Support Meson #12

nullgemm opened this issue Oct 8, 2021 · 5 comments

Comments

@nullgemm
Copy link

nullgemm commented Oct 8, 2021

Hi, I would like to add support for SheenBidi in libraqm (issue), which uses the increasingly popular Meson build system - as do all of its current dependencies. It would be amazing if SheenBidi supported Meson as well, since it can automatically build libraries that also use it when they are not installed on the host system (details here). Given SheenBidi does not have a package in most distros, Meson really is a must-have for us. Is supporting it something you can do?

Thanks :)

@mta452
Copy link
Member

mta452 commented Oct 8, 2021

Hi, I'm new to this system but I have added experimental support for the Meson build system. The code is pushed in feature/meson branch. Please let me know if it works for you.

@nullgemm
Copy link
Author

nullgemm commented Oct 8, 2021

Thank you very much for making theses changes so quickly!
I'll let you know how it goes for me :)

@nullgemm
Copy link
Author

Seems good so far with a few changes to allow Meson to build SheenBidi as a subproject.
If you don't mind making these changes I think we can close the issue :)

diff --git a/meson.build b/meson.build
index 937d4b9..75810c2 100644
--- a/meson.build
+++ b/meson.build
@@ -30,3 +30,7 @@ sheenbidi_library = library('sheenbidi',
   c_args: ['-DSB_CONFIG_UNITY'],
   version: '2.4',
   install: true)
+
+libsheenbidi_dep = declare_dependency(
+  include_directories : sheenbidi_includes,
+  link_with : sheenbidi_library)

@mta452
Copy link
Member

mta452 commented Oct 12, 2021

I have added the dependency line.
Please verify if everything is working ok, then I'll merge the branch in master.

@nullgemm
Copy link
Author

nullgemm commented Oct 12, 2021

Looks good to me. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants