Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复多标签页保活问题 #523

Merged
merged 1 commit into from
May 26, 2023

Conversation

ngyyuusora
Copy link
Collaborator

@ngyyuusora ngyyuusora commented May 26, 2023

(missing detect adppend multi tabs, refer e8509fd)

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

Closed #522

💡 需求背景和解决方案

按之前的设计,通过ignoreCacheRoutes实现禁用keepalive和多标签页(因为多标签依赖页面需要有保活能力,没有保活能力页面,不该进行多标签页的处理吧)。在https://github.com/Tencent/tdesign-vue-next-starter/pull/470变更后,没有对新增的meta.keepAlive判断是否将路由添加至多标签页。
增加判断meta.keepAlive !== false解决

📝 更新日志

  • fix: 修复多标签页保活问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2023

完成

@timi137137
Copy link
Collaborator

pls fix lint error

@ngyyuusora ngyyuusora force-pushed the feat/meta-keepalive branch from b0d419e to 79dd407 Compare May 26, 2023 05:30
@ngyyuusora ngyyuusora force-pushed the feat/meta-keepalive branch from 79dd407 to 4d21fc5 Compare May 26, 2023 05:34
@ngyyuusora
Copy link
Collaborator Author

pls fix lint error

抱歉啊现在应该修复了,本地运行lint无报错了
image

@timi137137 timi137137 changed the title fix: tabs-router, supports route.meta.keepAlive fix: 修复多标签页保活问题 May 26, 2023
@timi137137 timi137137 merged commit 89ccf19 into Tencent:develop May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tabs-router] 路由设定了meta.keepAlive为false仍然会被添加到tabs-router多标签页
2 participants