fix: 兼容主应用拦截原生的createElement #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
很棒的工作，我刚想这么做 pr 就做好了 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run test通过详细描述
当主应用需要拦截原生的
createElement时，自然会将createElement的this指向主应用的document。然而，目前在
wujie的proxyDocument中，是统一使用主应用的createElement，并尝试将this指向iframe的document。在使用过程中发现，如果
wujie的proxyDocument中，执行了被主应用改写过的createElement导致this最终指向主应用的document，会导致子应用内的节点，element instanceof HTMLElement得到false。因此，在
wujie的proxyDocument中改为使用同域iframe的createElement方法。主应用拦截原生的createElement可能导致子应用内instanceof异常 #274