Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
某些页面使用降级模式,发现一些事件监听器丢失。
经排查,此处:
recordEventListeners:
if (!elementListenerList.find((listener) => listener.handler === handler)) {
这个判断只判断handler一样就是认为是相同事件监听器,不进行缓存,根据addEventListener的参数,type、handler、options、useCapture、wantsuntrusted五元组共同组成不同事件监听器,因此type不同、handler相同也应该缓存下来。
改为:
if (!elementListenerList.find((listener) => listener.type === type && listener.handler === handler))
应该能兼容99%的情况。
详细描述
fixes #757