Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add share simulation method #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add share simulation method #101

wants to merge 1 commit into from

Conversation

marcusmolchany
Copy link
Contributor

@marcusmolchany marcusmolchany commented Aug 24, 2023 •
edited
Loading

fixes #100

todo:

  • add changest

@marcusmolchany marcusmolchany requested a review from a team August 24, 2023 22:30
@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2023

⚠️ No Changeset found

Latest commit: 5ad532b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@marcusmolchany marcusmolchany temporarily deployed to CI August 24, 2023 22:31 — with GitHub Actions Inactive
maleksandar
maleksandar suggested changes Aug 29, 2023
View reviewed changes
lib/executors/Simulator.ts
@@ -302,4 +312,19 @@ export class Simulator {
handleError(error);
}
}

/**
* Makes the dashboard page for a simulation that was created with `save` or `save_if_fails`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes the dashboard page for a simulation publicly viewable

Is a good enough comment, since we might change the exact name of the props used for this case.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1

@marcusmolchany
Copy link
Contributor Author

@maleksandar @celernetworkcoloros anything you need from me to get this merged in?

@maleksandar
Copy link
Contributor

@maleksandar @celernetworkcoloros anything you need from me to get this merged in?

Hi @marcusmolchany,

I'm no longer involved in maintaining/developing this package, so I'll have to redirect you towards @theDoubleBubble or @krunicn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhtuananhne dinhtuananhne dinhtuananhne left review comments

@maleksandar maleksandar maleksandar requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add method for /simulations/:id/share endpoint in Simulator.ts
3 participants
@marcusmolchany @maleksandar @dinhtuananhne