We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First of all, restructure the repo: Factor applications out of tests. Make test fold contain real tests.
Some more minor issues:
https://github.com/TensorBFS/TropicalTensors.jl/blob/2d/test/test_gpu.jl#L7 consider defining identity matrix ('eye') for Tropical tensor
https://github.com/TensorBFS/TropicalTensors.jl/blob/2d/test/test_gpu.jl#L22 use multiple dispatch rather than if else
https://github.com/TensorBFS/TropicalTensors.jl/blob/2d/test/test_gpu.jl#L31 same as above
https://github.com/TensorBFS/TropicalTensors.jl/blob/2d/test/test_gpu.jl#L67 return Array{T, N} rather than nested Array (use it to dispatch on array type and datatype)
The text was updated successfully, but these errors were encountered:
No branches or pull requests
First of all, restructure the repo: Factor applications out of tests. Make test fold contain real tests.
Some more minor issues:
https://github.com/TensorBFS/TropicalTensors.jl/blob/2d/test/test_gpu.jl#L7 consider defining identity matrix ('eye') for Tropical tensor
https://github.com/TensorBFS/TropicalTensors.jl/blob/2d/test/test_gpu.jl#L22 use multiple dispatch rather than if else
https://github.com/TensorBFS/TropicalTensors.jl/blob/2d/test/test_gpu.jl#L31 same as above
https://github.com/TensorBFS/TropicalTensors.jl/blob/2d/test/test_gpu.jl#L67 return Array{T, N} rather than nested Array (use it to dispatch on array type and datatype)
The text was updated successfully, but these errors were encountered: