Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL encoding is missing #19

Closed
juraj-hrivnak opened this issue Feb 25, 2024 · 6 comments
Closed

URL encoding is missing #19

juraj-hrivnak opened this issue Feb 25, 2024 · 6 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@juraj-hrivnak
Copy link

URLs with a whitespace or a special character like § fail to download.
A proper URL encoding for URLs would be appreciated.

I can recommend this library (the JVM version of it).

@juraj-hrivnak
Copy link
Author

juraj-hrivnak commented Feb 25, 2024

Here is my log: https://mclo.gs/gm2ejws
And here is my config: mod-director.zip

@Lylythii Lylythii added bug Something isn't working enhancement New feature or request labels Feb 25, 2024
@ACGaming
Copy link
Member

ACGaming commented Aug 10, 2024

Certainly not the nicest approach, but this works just fine:

{
    "url": "https://mediafilez.forgecdn.net/files/2668/311/%C2%A7c%C2%A7lCream%20%C2%A77Cuisine%20Resource%20Pack%20-%200.5.0.zip",
    "folder": "resourcepacks"
}

@juraj-hrivnak
Copy link
Author

Thanks. I tried this before and it did not work. Has anything changed since then?

@ACGaming
Copy link
Member

Untouched for a longer time, tested with 1.8.3.

@juraj-hrivnak
Copy link
Author

Okay, that works. I fixed it for Pakku.
If this is ever gonna change, I hope it stays backwards compatible with the encoded URLs.

@ACGaming ACGaming closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2024
@juraj-hrivnak
Copy link
Author

The problem is again that the encoded file names don't decode, so you end up with file names like this:
%C2%A7c%C2%A7lCream%20%C2%A77Cuisine%20Resource%20Pack%20-%200.5.0.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants