Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization of terria #3785

Closed
zoran995 opened this issue Nov 18, 2019 · 3 comments
Closed

Internationalization of terria #3785

zoran995 opened this issue Nov 18, 2019 · 3 comments

Comments

@zoran995
Copy link
Collaborator

Starting this so we can track work on internationalization of app, hope it is ok

@zoran995
Copy link
Collaborator Author

zoran995 commented Nov 21, 2019

@rowanwins and @soyarsauce How we should proceed with data in defaults.jsx? I am not sure is it possible to keep it as it is with i18next

@soyarsauce
Copy link
Contributor

soyarsauce commented Nov 21, 2019

We should continue the rest of the internationalisation efforts in the work done through #3787, and stop using defaults.jsx for i18n - however it could still be useful for defining other ways to extend terria (see https://github.com/TerriaJS/de-australia-map/pull/29/files#diff-e7c237f2b6a10131a063f7b5740c39aaR5)

@zoran995
Copy link
Collaborator Author

zoran995 commented Nov 28, 2019

I will post some questions:

  • language switch:

    • Where should we put a button for users to switch languages of the map in the TerriaMap or TerriaJS? The user should have an option to define languages that he want to enable. The switcher should not be visible by default if there is only one language in the Language folder.
    • From the design perspective dropdown or something else, and where to position it?
    • Should we show the country flag next to language name (if yes then user should also have option to choose that)?
  • should we split translation.json file to multiple parts to separate ReactViews translation from the rest (core, models and map which are biger groups in the translation.json)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants