Inserting vs updating models from share data (or initSources)

[nf-s]

Related to #4975

@steve9164

If share data contains a model which isn't in the catalog - it will result in a new incomplete model being created.

Does serialisation save enough attributes that upsertModelFromJson thinks it can create a new model?
upsertModelFromJson should really be replaced with update + insert functions
But is it always easy to work out when share data should use update and when it should insert?
E.g. user added models should be inserted when deserialised, not updated

Nick:

One issue here is with how I create new models in CatalogFunctions (eg for WPS results) - the entire model is dumped into user stratum so it can be shared.

So it might be difficult to determine if share data should be updated or inserted - unless we add a catalogModel flag or something if it exists outside user stratum

Might be worth making a nicer error message: