Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle size too large #140

Closed
CNFeffery opened this issue Jan 5, 2023 · 6 comments
Closed

Bundle size too large #140

CNFeffery opened this issue Jan 5, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@CNFeffery
Copy link

How to effectively reduce the bundle size after using json-viewer.
image
@rtritto rtritto mentioned this issue Jan 11, 2023
Merged
@pionxzh pionxzh added the enhancement New feature or request label Jan 11, 2023
@pengbins pengbins mentioned this issue Jan 12, 2023
Closed
6 tasks
@rtritto
Copy link
Contributor

rtritto commented Jan 12, 2023

Move all @emotion/* and @mui/* dependencies to peer dependencies?

@pionxzh
Copy link
Collaborator

pionxzh commented Jan 14, 2023

Move all @emotion/* and @mui/* dependencies to peer dependencies?

I think you are right. They should be moved out according to mui/material-ui#35006

@pionxzh
Copy link
Collaborator

pionxzh commented Jan 14, 2023

@mui/icons-material has been removed in v2.13.0

@pionxzh pionxzh closed this as completed Jan 14, 2023
@pionxzh pionxzh mentioned this issue Jan 15, 2023
Merged
@pionxzh
Copy link
Collaborator

pionxzh commented Jan 15, 2023

Move all @emotion/* and @mui/* dependencies to peer dependencies?

I think you are right. They should be moved out according to mui/material-ui#35006

The issue is that I'm worrying about moving them to peer is considered a BREAKING change.
What do you guys think? 😮‍💨

@rtritto
Copy link
Contributor

rtritto commented Jan 15, 2023 •
edited
Loading

@pionxzh Yes, it's a breaking change.
Peer dependencies should be added to install commands on README

@pionxzh
Copy link
Collaborator

pionxzh commented Jan 19, 2023

We might do a breaking change in #185 to move emotion to the peer after CNY, which will bump the major to V3.
Umm @mui will also be moved, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pionxzh @rtritto @CNFeffery