Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add vite as dev dependency #148

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

rtritto
Copy link
Contributor

@rtritto rtritto commented Jan 11, 2023

Console output after yarn install:

➤ YN0002: │ @textea/json-viewer@workspace:. doesn't provide vite (pba117), requested by @vitejs/plugin-react
➤ YN0002: │ @textea/json-viewer@workspace:. [897a1] doesn't provide vite (pb4639), requested by @vitejs/plugin-react

@vitejs/plugin-react dev dependency has vite as peer dependency.
All transitive dependency should be installed respectively.

@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for any-viewer failed.

Name Link
🔨 Latest commit b7da6ba
🔍 Latest deploy log https://app.netlify.com/sites/any-viewer/deploys/63bf074a58df6f00092df6ea

Copy link
Collaborator

@pionxzh pionxzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 87.90% // Head: 87.90% // No change to project coverage 👍

Coverage data is based on head (b7da6ba) compared to base (8313a04).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #148   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files          18       18           
  Lines        1902     1902           
  Branches      338      338           
=======================================
  Hits         1672     1672           
  Misses        230      230           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pionxzh pionxzh changed the title Add vite as dev dependency fix: add vite as dev dependency Jan 11, 2023
@pionxzh pionxzh merged commit b85bbf9 into TexteaInc:main Jan 11, 2023
@rtritto rtritto deleted the add-vite-devdep branch January 11, 2023 19:17
Yazawazi pushed a commit that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants