Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): remove left margin in key-value separator #153

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

rtritto
Copy link
Contributor

@rtritto rtritto commented Jan 12, 2023

Before:
image

After:
image

@netlify
Copy link

netlify bot commented Jan 12, 2023

Deploy Preview for any-viewer failed.

Name Link
🔨 Latest commit 5cd4a99
🔍 Latest deploy log https://app.netlify.com/sites/any-viewer/deploys/63c081cca0c7520008022325

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 87.90% // Head: 87.90% // No change to project coverage 👍

Coverage data is based on head (5cd4a99) compared to base (8313a04).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files          18       18           
  Lines        1902     1902           
  Branches      338      338           
=======================================
  Hits         1672     1672           
  Misses        230      230           
Impacted Files Coverage Δ
src/components/DataKeyPair.tsx 71.69% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pionxzh pionxzh changed the title Set margin from x to right in key-value separator fix(ui): remove left margin in key-value separator Jan 13, 2023
Copy link
Collaborator

@pionxzh pionxzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pionxzh pionxzh merged commit 4d6a858 into TexteaInc:main Jan 13, 2023
@rtritto rtritto deleted the separator-margin-right branch January 13, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants