Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] table line missing characters in windows terminal but not cmd #186

Closed
GSGBen opened this issue Jul 28, 2020 · 6 comments
Closed

[BUG] table line missing characters in windows terminal but not cmd #186

GSGBen opened this issue Jul 28, 2020 · 6 comments
Labels
accepted Task was accepted Needs triage

Comments

@GSGBen
Copy link

GSGBen commented Jul 28, 2020

Describe the bug

Running python -m rich in the latest windows terminal outputs three ??? characters in the line under the column headings.

To Reproduce

image

Platform

  • Windows 10
  • Windows terminal 1.1.2021.0
  • Python 3.8.2
  • Rich 4.2.0
  • Happens with Cascadia, Cascadia Mono, Consolas. Assuming all fonts
  • Doesn't happen in cmd/powershell/conemu
@willmcgugan
Copy link
Collaborator

This is actually a bug in Python itself https://bugs.python.org/issue37871

A workaround would be to chop Rich output in to parts smaller than the buffer size used by Python.

@willmcgugan willmcgugan added the accepted Task was accepted label Jul 29, 2020
@willmcgugan
Copy link
Collaborator

Fixed in v4.2.1

@GSGBen
Copy link
Author

GSGBen commented Jul 29, 2020

Wow, thanks!

@GSGBen
Copy link
Author

GSGBen commented Jul 30, 2020

Tested in 4.2.1 and it still seems to be occurring:

image

~> pip list | sls rich

rich               4.2.1

@willmcgugan willmcgugan reopened this Jul 30, 2020
@willmcgugan
Copy link
Collaborator

Try 4.2.2

Rich now writes a line at a time, which seems to fix it. I can't reproduce the problem on Windows 10.

@GSGBen
Copy link
Author

GSGBen commented Aug 2, 2020

Tested on the original PC and it still happens, but tested on another Windows 10 one and it doesn't, so I'm chalking it up to an environment issue on this PC. Thanks for your work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Task was accepted Needs triage
Projects
None yet
Development

No branches or pull requests

2 participants