Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Add binary_units argument to all relevant progress columns (TransferSpeedColumn, FileSizeColumn and TotalFileSizeColumn) #3466

Open
sbraz opened this issue Aug 24, 2024 · 2 comments

Comments

@sbraz
Copy link
Contributor

sbraz commented Aug 24, 2024

How would you improve Rich?
Hello,
In 630ed8b and 5ef33ae, DownloadColumn got support for using multiples of 1024. However, other columns do not have a binary_units argument.

This was already mentioned in #2034 and I feel like it would be useful to be consistent with other software.

What problem does it solve for you?

When I'm watching a transfer, I expect sizes to be displayed as multiples of 1024 bytes. This is what rsync --info=progress2, curl, wget and lsblk do. Even ls also does this unless --si is passed.

Copy link

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory

@jakub-mrow
Copy link

I would like to contribute to this feature. Would it be a good idea to start with FileSizeColumn, TotalFileSizeColumn and TransferSpeedColumn?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants