Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo app no longer logs message in on_mount #1498

Closed
davep opened this issue Jan 5, 2023 · 3 comments · Fixed by #1581
Closed

Demo app no longer logs message in on_mount #1498

davep opened this issue Jan 5, 2023 · 3 comments · Fixed by #1581
Labels
bug Something isn't working Task

Comments

@davep
Copy link
Contributor

davep commented Jan 5, 2023

As noted by @lllama over on Discord:

Looks like the add_note call in on_mount in the demo app doesn't work? Saving screenshots adds a note okay but the initial one seems to be missing.

Testing here, the last time this worked was 0.7.0. This stops working as of 0.8.0.

@davep davep added the bug Something isn't working label Jan 5, 2023
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory

@davep
Copy link
Contributor Author

davep commented Jan 9, 2023

Worth noting that this doesn't seem to be a general issue with TextLog itself; this code:

from textual.app        import App, ComposeResult
from textual.containers import Vertical
from textual.widgets    import Header, Footer, TextLog

class TextLogTester( App[ None ] ):

    def compose( self ) -> ComposeResult:
        yield Header()
        yield Vertical( TextLog() )
        yield Footer()

    def on_mount( self ) -> None:
        self.query_one( TextLog ).write( "This was done on mount" )

if __name__ == "__main__":
    TextLogTester().run()

works as expected with Textual v0.9.1.

@davep davep added the Task label Jan 10, 2023
@davep davep linked a pull request Jan 17, 2023 that will close this issue
@github-actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant