Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.20.0+ breaks dark mode on Mac terminal #2359

Closed
MaineTim opened this issue Apr 22, 2023 · 3 comments · Fixed by #2360
Closed

0.20.0+ breaks dark mode on Mac terminal #2359

MaineTim opened this issue Apr 22, 2023 · 3 comments · Fixed by #2360

Comments

@MaineTim
Copy link

I have been using 0.16.0 "in production" successfully since it came out. I updated to 0.20.1 today to get the datatable row_remove functionality, and found that the update breaks dark mode on the Mac standard terminal. I went back and stepped through the versions, and it's 0.20.0 where the change occurs.

Instead of the usual dark mode with correct borders, the window now comes up as white (which is the terminal normal color) with grey text and borders, the only color is the highlighted row, which is now solid green (instead of the yellow background). The vertical sides of an input widget are also "broken".

I know the Mac terminal is problematic to support, but as it was all working fine up til now, I thought I'd report it in case it's something minor that needs to be tweaked. All works fine under iterm2.

If I can be of any help, let me know.

## Versions

| Name    | Value  |
|---------|--------|
| Textual | 0.20.0 |
| Rich    | 13.3.4 |

## Python

| Name           | Value                                                 |
|----------------|-------------------------------------------------------|
| Version        | 3.11.3                                                |
| Implementation | CPython                                               |
| Compiler       | Clang 14.0.0 (clang-1400.0.29.202)                    |
| Executable     | /Users/tim/Projects/media_browser/venv3113/bin/python |

## Operating System

| Name    | Value                                                                                                 |
|---------|-------------------------------------------------------------------------------------------------------|
| System  | Darwin                                                                                                |
| Release | 21.6.0                                                                                                |
| Version | Darwin Kernel Version 21.6.0: Thu Sep 29 20:13:46 PDT 2022; root:xnu-8020.240.7~1/RELEASE_ARM64_T8101 |

## Terminal

| Name                 | Value                |
|----------------------|----------------------|
| Terminal Application | Apple_Terminal (445) |
| TERM                 | xterm-256color       |
| COLORTERM            | *Not set*            |
| FORCE_COLOR          | *Not set*            |
| NO_COLOR             | *Not set*            |

## Rich Console options

| Name           | Value                |
|----------------|----------------------|
| size           | width=214, height=34 |
| legacy_windows | False                |
| min_width      | 1                    |
| max_width      | 214                  |
| is_terminal    | True                 |
| encoding       | utf-8                |
| max_height     | 34                   |
| justify        | None                 |
| overflow       | None                 |
| no_wrap        | False                |
| highlight      | None                 |
| markup         | None                 |
| height         | None                 |
@github-actions
Copy link

We found the following entries in the FAQ which you may find helpful:

Feel free to close this issue if you found an answer in the FAQ. Otherwise, please give us a little time to review.

This is an automated reply, generated by FAQtory

@willmcgugan
Copy link
Collaborator

Thanks for the report. There will be a fix in the next version (some time next week)

@github-actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants