Placeholder cycle per app

[willmcgugan]

The placeholder stores the current color in a classvar.

This means that a second app will start where the previous app left off. And may return a different color from the first iteration.

Not much of an issue in practice, but in the docs the colors change every screenshot. I think we need a separate cycle per app. Suggest we have an independent sequence for each app instance.

[rodrigogiraoserrao]

We already have reset_color_cycle as an attempt to fix that, but I don't like it.
Can I get rid of reset_color_cycle while I'm at it?

[willmcgugan]

Sure

[willmcgugan]

You might be able to do this with a WeakKeySet where the keys are apps. Just a thought.

[rodrigogiraoserrao]

You might be able to do this with a WeakKeySet where the keys are apps. Just a thought.

Thanks. I was doing it with a standard dictionary with app IDs as keys.

[willmcgugan]

That would work. Downside is that the app IDs wouldn't be removed when the app is deleted.

[rodrigogiraoserrao]

But that's also a marginal issue, no?
How many apps will you create and destroy after loading the Placeholder..?

[willmcgugan]

It's unlikely to be an issue, sure. But its not much more work to do the weak dict. May as well?

[github-actions]

Don't forget to star the repository!

Follow @textualizeio for Textual updates.