Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Footer flicker with overlapping key bindings #4573

Closed
TomJGooding opened this issue May 29, 2024 · 2 comments · Fixed by #4584
Closed

Initial Footer flicker with overlapping key bindings #4573

TomJGooding opened this issue May 29, 2024 · 2 comments · Fixed by #4584

Comments

@TomJGooding
Copy link
Contributor

I noticed there seems to be a initial flicker in the Footer if there are overlapping bindings. Try running the app in the MRE below, where the space key has bindings both in the app and the widget, and watch the footer. This wasn't the case before dynamic bindings, from a very quick look into this the commit is aa6e144.

from textual.app import App, ComposeResult
from textual.widgets import Checkbox, Footer


class ExampleApp(App):
    BINDINGS = [
        ("space", "bell", "Ring the bell"),
        ("q", "quit", "Quit"),
    ]

    def compose(self) -> ComposeResult:
        yield Checkbox("Watch the Footer")
        yield Footer()


if __name__ == "__main__":
    app = ExampleApp()
    app.run()
Copy link

We found the following entry in the FAQ which you may find helpful:

Feel free to close this issue if you found an answer in the FAQ. Otherwise, please give us a little time to review.

This is an automated reply, generated by FAQtory

@TomJGooding TomJGooding changed the title Intiial Footer flicker with overlapping key bindings Initial Footer flicker with overlapping key bindings May 29, 2024
Copy link

github-actions bot commented Jun 2, 2024

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant