From 6c459a5cd0f44d68a6a8a93ab8de2e41b2ed2a03 Mon Sep 17 00:00:00 2001 From: Will McGugan Date: Sat, 6 Apr 2024 11:40:55 +0100 Subject: [PATCH 1/2] fix for prioirty bindings --- src/textual/app.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/textual/app.py b/src/textual/app.py index fc073798c5..2f8cfd7c4e 100644 --- a/src/textual/app.py +++ b/src/textual/app.py @@ -865,10 +865,9 @@ def namespace_bindings(self) -> dict[str, tuple[DOMNode, Binding]]: """ bindings_map: dict[str, tuple[DOMNode, Binding]] = {} - for namespace, bindings in reversed(self._binding_chain): + for namespace, bindings in self._binding_chain: for key, binding in bindings.keys.items(): - existing_key_and_binding = bindings_map.get(key) - if existing_key_and_binding: + if existing_key_and_binding := bindings_map.get(key): _, existing_binding = existing_key_and_binding if binding.priority and not existing_binding.priority: bindings_map[key] = (namespace, binding) From 5e420cb2febda4f9d812f02065a6ca0a6f4bec76 Mon Sep 17 00:00:00 2001 From: Will McGugan Date: Sat, 6 Apr 2024 11:42:16 +0100 Subject: [PATCH 2/2] changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f06e22249c..aa34a0554e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). ### Fixed - Fixed issue with inline mode and multiple screens https://github.com/Textualize/textual/pull/4393 +- Fixed issue with priority bindings https://github.com/Textualize/textual/pull/4395 ### Changed