Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to embedded-hal 1.0.0-rc.1 #2

Closed
clintfred opened this issue Dec 6, 2023 · 3 comments · Fixed by #3
Closed

Upgrade to embedded-hal 1.0.0-rc.1 #2

clintfred opened this issue Dec 6, 2023 · 3 comments · Fixed by #3

Comments

@clintfred
Copy link

Thanks for your crate!

It look like the embedded-hal 1.0 release is scheduled for 12/28/2023 and the rc.1 release should have the same API unless something goes off the rails.

Is there any work that needs to be done to upgrade?

@TeyKey1
Copy link
Owner

TeyKey1 commented Dec 11, 2023

Hi @clintfred

Thanks for letting me know about the future release of v1.0. Looks like it's really happening soon 😄
I think there will be some small changes needed to pca9535 lib, but it should not be too drastic as far as I saw. We removed the IO-Pin trait in #1 which I'd like to get back in. But looks like this is not in 1.0 so it can be skipped for now.

I might need to make a few adjustments to the hardware testing, but rppal seems to support v1.0 rc2 already, so I only might need to patch shared-bus to v1.0 rc2 for now.

In case you need pca9535 to support v1.0 rc2 I can create a release candidate for you, otherwise I plan to release v2.0.0 of pca9535 once v1.0 of embedded-hal is released.

@clintfred
Copy link
Author

Thank you for your response. I can wait for the 2.0 release; no worries.

FYI: I am using your crate with linux-embedded-hal.

If you need any support or feedback, I will try to help, just lmk.

@TeyKey1
Copy link
Owner

TeyKey1 commented Dec 11, 2023

Ok, so I will wait for the official release. The update is now merged into master.

I'm always happy for any feedback regarding the library usage. In case there's something that is hard to achieve or does not work.

It's always nice to have people using the library in combination with other hardware and providing feedback in case anything does not work correctly. I myself only use it in combination with rppal on a Raspberry Pi 4 which is also used for the hardware based tests in this lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants