Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ› Bug โžพ Variant is not properly defined #1935

Closed
1 of 6 tasks
zamrokk opened this issue Apr 16, 2024 · 2 comments
Closed
1 of 6 tasks

๐Ÿ› Bug โžพ Variant is not properly defined #1935

zamrokk opened this issue Apr 16, 2024 · 2 comments
Labels
bug Something isn't working triage Requires triage

Comments

@zamrokk
Copy link

zamrokk commented Apr 16, 2024

๐Ÿšฅ Status (Internal Taqueria Team Use Only)

  • ๐Ÿ”ฌ Investigated and Verified
  • โš—๏ธ Solution Identified and Designed
  • ๐Ÿงซ Dev Implementation of Fix
  • ๐Ÿงช Fix Tested and Validated
  • ๐Ÿ† PR Merged

๐Ÿ†˜ What happened?

I generated types using taq generate
When I try to display a status field that is a variant type, it did not display, so I debugged it and I found that typing does not match

๐Ÿ†˜ Steps to Reproduce?

  1. use a ligo variant : export type STATUS = ["ACTIVE"] | ["RECOVERING", address, timestamp] | ["DEAD"]; on a contract storage

  2. deploy this contract with a status RECOVERING

  3. generate the types on a dapp and try to display the status + the embedded address and the timestamp.

Instead of expected field 0 and 1 , the values are stored on fields 3 and 4

image

๐Ÿชต Relevant log output

"@taquito/taquito": "^19.2.0",

taqueria   0.50.0

"@taqueria/plugin-contract-types": "^0.50.0",

๐Ÿ˜ How impactful is this bug?

๐Ÿค” Notable but managable

โฑ๏ธ Prevalance

No response

๐Ÿ’ป Operating System

Windows -> WSL

๐Ÿ•ธ๏ธ System Architecture

x64

๐ŸŒฎ Taqueria Version

0.50.0

๐ŸŒฟ Node.js Version

v18.19.1

โ˜Ž๏ธ Contact Details

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@zamrokk zamrokk added bug Something isn't working triage Requires triage labels Apr 16, 2024
@mweichert
Copy link
Collaborator

Closing this, as we determined this to be a bug with Taquito.

@zamrokk
Copy link
Author

zamrokk commented Apr 19, 2024

Thank you Michael !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Requires triage
Projects
None yet
Development

No branches or pull requests

2 participants