Skip to content

Commit

Permalink
Note regarding label vs index
Browse files Browse the repository at this point in the history
  • Loading branch information
TheChymera committed Jan 18, 2022
1 parent 1fc9b95 commit 7571fbb
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion tools/schemacode/schemacode/validator.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@


def _get_paths(bids_dir):
"""Get all paths from a directory, excluding `.git` subdirectory."""
"""Get all paths from a directory, excluding hidden subdirectories from data distribution."""
exclude_subdirs=[
'/.dandi',
'/.datalad',
Expand Down Expand Up @@ -123,6 +123,9 @@ def load_entities(
-----
* Couldn't find where the `label` type is defined as alphanumeric, hard-coding `entity_definitions["subject"]["format"]`-type entries as`[a-z,A-Z,0-9]*?` for the time being.
Apparently there is a `label` (alphanumeric) versus `index` (integer) specification:
https://github.com/bids-standard/bids-specification/issues/956#issuecomment-992967479
but this is not yet used in the YAML.
* Suggest to BIDS-specification to remove the periods from the extensions, the leading period is not part of the extension, but a delimiter defining the fact that it's an extension. Code sections marked as `Making it period-safe` should be edited when this fix is in, though they will work in any case.
* More issues in comments.
* Using pre 3.8 string formatting for legibility.
Expand Down

0 comments on commit 7571fbb

Please sign in to comment.