Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use prefix at joinWhere #800

Closed
DanielBGomez opened this issue Nov 14, 2018 · 0 comments
Closed

Use prefix at joinWhere #800

DanielBGomez opened this issue Nov 14, 2018 · 0 comments

Comments

@DanielBGomez
Copy link
Contributor

I was trying the joinWhere method [#294] but it wasn't working as expected [#513] so i took a look at the code and realized that the table prefix isn't used [#513]. This affects at _buildJoin() because in the condition if (!empty($this->_joinAnd) && isset($this->_joinAnd[$joinStr])) { the $joinStr has the prefix.
DanielBGomez added a commit to DanielBGomez/PHP-MySQLi-Database-Class that referenced this issue Nov 14, 2018
@DanielBGomez
FIX ThingEngineer#800 joinWhere() not using $prefix
f898f62
DanielBGomez added a commit to DanielBGomez/PHP-MySQLi-Database-Class that referenced this issue Nov 20, 2018
@DanielBGomez
FIX ThingEngineer#800 joinWhere() not using $prefix
e56680a
@avbdr avbdr closed this as completed in eaf1f6c Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DanielBGomez