DeprecationWarning at aiofiles.os:8

[HacKanCuBa]

Hi there! Pytest is correctly complaining about the use of @coroutine decorator at aiofiles.os line 8. This is for the current latest 0.5.0 version.

aiofiles/aiofiles/os.py

Lines 7 to 16 in 258e956

	def wrap(func):
	@asyncio.coroutine
	@wraps(func)
	def run(*args, loop=None, executor=None, **kwargs):
	if loop is None:
	loop = asyncio.get_event_loop()
	pfunc = partial(func, *args, **kwargs)
	return loop.run_in_executor(executor, pfunc)
	return run

The fix would be to use async def directly:

def wrap(func):
    @wraps(func)
    async def run(*args, loop=None, executor=None, **kwargs):
        if loop is None:
            loop = asyncio.get_event_loop()
        pfunc = partial(func, *args, **kwargs)
        return loop.run_in_executor(executor, pfunc)

    return run

[Tinche]

Agreed, could you create a quick PR?

[gyermolenko]

Agreed, could you create a quick PR?

related #54 (! please note that it also changes return type of the wrapped func)

[HacKanCuBa]

Agreed, could you create a quick PR?

Sure, give me 5' :)

[HacKanCuBa]

Done in #75

[HacKanCuBa]

Agreed, could you create a quick PR?

related #54 (! please note that it also changes return type of the wrapped func)

Woops, sorry I missed this. Both PRs clashes, so I guess we need to pick one.

[HacKanCuBa]

I saw that Travis failed in my PR so I checked out the project locally and saw that, at least for py3.8, tests are failing for what is mentioned in #54. With that patch all tests passed.
So, all in all, I think we need to go for #54, which is more complete and fixes other issue, instead of my patch.

[Tinche]

Merged that one in! Can this issue now be closed?

[HacKanCuBa]

Sure do! I'm closing it. Thanks!