Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace set-output commands which will be deprecated #16

Closed
Tiryoh opened this issue Oct 23, 2022 · 4 comments · Fixed by #17
Closed

replace set-output commands which will be deprecated #16

Tiryoh opened this issue Oct 23, 2022 · 4 comments · Fixed by #17
Labels
good first issue Good for newcomers

Comments

@Tiryoh
Copy link
Owner

Tiryoh commented Oct 23, 2022

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
@phoeniixhawk
Copy link
Contributor

Great plugin btw, I think we can fix this with

echo "job_id=${job_id}" >> $GITHUB_OUTPUT
echo "html_url=${html_url}" >> $GITHUB_OUTPUT

@Tiryoh
Copy link
Owner Author

Tiryoh commented Nov 18, 2022

Hi @phoeniixdotcom,
Thanks for your report!
If you don't mind, could you send me a PR?

@phoeniixhawk
Copy link
Contributor

Sure, but I'm getting permission denied to push a feature branch. Could you give me rights?

@phoeniixhawk
Copy link
Contributor

Oh, nevermind, initiated PR from my acct. Thx!

@Tiryoh Tiryoh added good first issue Good for newcomers Status: In Progress Work in Progress labels Nov 19, 2022
@Tiryoh Tiryoh linked a pull request Nov 19, 2022 that will close this issue
Updating set-output to recommended format #17
Merged
@Tiryoh Tiryoh removed the Status: In Progress Work in Progress label Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating set-output to recommended format phoeniixhawk/gha-jobid-action
2 participants
@phoeniixhawk @Tiryoh