Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to meta_or_ctrl for macos #549

Closed
TokisanGames opened this issue Nov 10, 2024 · 8 comments · Fixed by #568
Closed

Change to meta_or_ctrl for macos #549

TokisanGames opened this issue Nov 10, 2024 · 8 comments · Fixed by #568
Labels
bug Something isn't working important High priority
Milestone

Comments

@TokisanGames
Copy link
Owner

Description

On Macos ctrl+click is right-click and cannot be changed.

Instead change input detection to use Input.is_command_or_control_pressed(). Then the commands will be inverse: ctrl/cmd, alt mode: alt/option/keybind.

In the meantime, macos users can inverse by first clicking and holding, then pressing ctrl.

@TokisanGames TokisanGames added bug Something isn't working important High priority labels Nov 10, 2024
@TokisanGames TokisanGames added this to the 0.9 milestone Nov 10, 2024
@TokisanGames TokisanGames moved this to In Progress in Terrain3D Roadmap Nov 10, 2024
@matpersonne
Copy link

Hello, Yes for me it's totally impossible to remove region with ctrl + LMB (trackpad) MacOs

@TokisanGames
Copy link
Owner Author

Click+hold first, then press ctrl. Also sculpting and painting on a trackpad is extremely difficult anyway. I recommend getting an external mouse or tablet.

@RavMda
Copy link

RavMda commented Nov 25, 2024

I have tried it with external mouse, it still doesn't work

@TokisanGames
Copy link
Owner Author

The recommendation for an external mouse is for general sculpting, independent of this issue. Ctrl+click won't work on any input device until we can replace the key in code. Click+hold first, then pressing ctrl is the only way to get removal to work on a mac at the moment.

@TokisanGames
Copy link
Owner Author

TokisanGames commented Dec 8, 2024

Can one of you guys please edit editor.gd L272 and see if this works fine for you.

Change
modifier_ctrl = Input.is_key_pressed(KEY_CTRL)
to
modifier_ctrl = Input.is_key_pressed(KEY_CTRL) or Input.is_key_pressed(KEY_META)

It should change the cursor/toolbar when cmd is held, and perform the negative operation on cmd+click.

@TokisanGames
Copy link
Owner Author

Fixed by #568. Would still like testers of the above comment and/or #568.

@TokisanGames TokisanGames modified the milestones: 0.9, 1.0 Dec 9, 2024
@TokisanGames TokisanGames moved this from In Progress to Done in Terrain3D Roadmap Dec 10, 2024
@henriknh
Copy link

henriknh commented Dec 10, 2024

Hey! Thank you for looking into this! I tested this now on my MacBook Pro M2 15.1.1 on 0.9.3a and i found the above line at 276 instead.
If I move the mouse around the brush is white and when I left click the terrain is raised, as expected.
If I press and hold cmd and move the mouse around the brush is black instead and when I left click the terrain is lowered, so this seems to fix the issue!

@TokisanGames
Copy link
Owner Author

Thanks for the report. The fix has been merged in to main which is usable in nightly builds, but you can continue using this manual fix in the current version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working important High priority
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants