mackerel-*-plugins packages depend on distro-specific repository #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In RedHat-family distros, packages can be installed after Yumrepo[mackerel], while in Debian-family distros, `apt-get update` must be executed before package installation.
|
Thank you for your patch and a proposal. I will consider it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the merger of #13, plugin packages cannot be installed on Debian-like distros because of usage of Yumrepo resource.
In RedHat-family distros, packages can be installed after configuring Yumrepo[mackerel], while in Debian-family distros,
apt-get updatemust be executed before package installation.This patch is just a quick fix for the problem, but I suppose it would be good to refactor the manifest by splitting the
installclass into repository configuration phase and package installation phase.